Refactor: Split DMP Assistant custom stylesheets into separate blocks#1219
Draft
aaronskiba wants to merge 2 commits intointegrationfrom
Draft
Refactor: Split DMP Assistant custom stylesheets into separate blocks#1219aaronskiba wants to merge 2 commits intointegrationfrom
aaronskiba wants to merge 2 commits intointegrationfrom
Conversation
`grey-rebranding.scss` is imported after `rebranding.scss`, so its styling will take precedence.
- `margin-top: 0.6em;` was coped from `rebranding.scss` to `grey-rebranding.scss`. (`height: 200px` was never being used.)
- We can delete lines 113-124 from `rebranding.scss` because the following already exists in `grey-rebranding.scss`:
```
.nav-tabs, .nav-pills{ //_navs.scss
background-color: $color-alliance-digital-grey;
}
//_table.scss
thead th{
background-color: $color-alliance-digital-grey;
}
```
Break down the three large DMP Assistant stylesheets into smaller, maintainable partials under `app/assets/stylesheets/dmp-assistant/blocks/`. Each partial corresponds to or overrides matching a file in app/assets/stylesheets/blocks/, improving organization and clarity. However, `_close.scss` has also been added, which overrides Bootstrap’s default `_close.scss` for custom close button styling. NOTE: All block code has been reorganized for maintainability but retains its original sequence and @import order within the original files (i.e. @import "rebranding";, @import "rebranding-animation";, @import "grey-branding";.). Thus, this refactor should not result in any visual or behavioural changes.
Generated by 🚫 Danger |
Collaborator
Author
|
Will revisit this while/after working on the Bootstrap 5 upgrade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
grey-rebranding.scssis imported afterrebranding.scss, so its styling will take precedence.margin-top: 0.6em;was copied fromrebranding.scsstogrey-rebranding.scss. (height: 200pxwas never being used.)rebranding.scssbecause the following already exists ingrey-rebranding.scss:Break down the three large DMP Assistant stylesheets into smaller, maintainable partials under
app/assets/stylesheets/dmp-assistant/blocks/.Each partial corresponds to or overrides matching a file in app/assets/stylesheets/blocks/, improving organization and clarity. However,
_close.scsshas also been added, which overrides Bootstrap’s default_close.scssfor custom close button styling.NOTE: All block code has been reorganized for maintainability but retains its original sequence and @import order within the original files (i.e. @import "rebranding";, @import "rebranding-animation";, @import "grey-branding";.). Thus, this refactor should not result in any visual or behavioural changes.